[PATCH] D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/IR/Module.cpp:677
+std::string llvm::getUniqueName(StringRef BaseName, StringRef UniqueSuffix) {
+  // If the suffix comes from getUniqueModuleId() it may have a $ at the front.
+  // Remove that as it doesn't demangle nicely.
----------------
tejohnson wrote:
> Should getUniqueModuleId be changed to not put in the "$"? Looking at the other use sites, it is used for renaming comdats and types - can/should these get the same treatment via this function (use .llvm.moduleId instead of $moduleId)?
I agree, that function should be changed to use `.` instead of `$`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97484/new/

https://reviews.llvm.org/D97484