[PATCH] D97430: [SanitizerCoverage] Drop !associated on metadata sections
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 24 20:35:07 PST 2021
vitalybuka added a comment.
LGTM
If no more comment I'll accept tomorrow?
================
Comment at: llvm/lib/Transforms/Instrumentation/Instrumentation.cpp:94-95
// Make a new comdat for the function. Use the "no duplicates" selection kind
// for non-weak symbols if the object file format supports it.
Comdat *C = M->getOrInsertComdat(Name);
----------------
MaskRay wrote:
> vitalybuka wrote:
> > this comment does not match condition now
> Thanks. BTW: we can delete the `ModuleId` block entirely.
So it was added in D51902 and replaced with NoDuplicates for COFF in D54232
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97430/new/
https://reviews.llvm.org/D97430
More information about the llvm-commits
mailing list