[PATCH] D97430: [SanitizerCoverage] Drop !associated on metadata sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/Instrumentation.cpp:94-95
 
   // Make a new comdat for the function. Use the "no duplicates" selection kind
   // for non-weak symbols if the object file format supports it.
   Comdat *C = M->getOrInsertComdat(Name);
----------------
vitalybuka wrote:
> this comment does not match condition now
Thanks. BTW: we can delete the `ModuleId` block entirely.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:686-688
   GlobalsToAppendToCompilerUsed.push_back(Array);
-  MDNode *MD = MDNode::get(F.getContext(), ValueAsMetadata::get(&F));
-  Array->addMetadata(LLVMContext::MD_associated, *MD);
----------------
vitalybuka wrote:
> Why removing these lines does not change COFF behaviour ?
I'll amend the description: 

> This patch does change the object file output for COFF (`!associated` is ignored).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97430/new/

https://reviews.llvm.org/D97430