[PATCH] D97412: [Remarks] Provide more information about auto-init stores
Francis Visoiu Mistrih via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 24 15:50:01 PST 2021
thegameg added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/AutoInitRemark.cpp:29
+ if (Volatile)
+ R << " Volatile: " << NV("StoreVolatile", true) << ".";
+ if (Atomic)
----------------
paquette wrote:
> I think it may be worth handling the false case here as well. People may want to search for non-volatile and non-atomic stores in the remarks.
In my experience volatile/atomic auto-init stores are **very** uncommon. While I agree that it's convenient for scripts and such to have it anyway, I wonder if it doesn't pollute the remark message too much.
Maybe I can put it under `setExtraArgs`...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97412/new/
https://reviews.llvm.org/D97412
More information about the llvm-commits
mailing list