[PATCH] D97412: [Remarks] Provide more information about auto-init stores

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 15:26:51 PST 2021


paquette added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/AutoInitRemark.cpp:29
+  if (Volatile)
+    R << " Volatile: " << NV("StoreVolatile", true) << ".";
+  if (Atomic)
----------------
I think it may be worth handling the false case here as well. People may want to search for non-volatile and non-atomic stores in the remarks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97412/new/

https://reviews.llvm.org/D97412



More information about the llvm-commits mailing list