[PATCH] D97253: [llvm-objcopy] If input=output, preserve umask bits, otherwise drop S_ISUID/S_ISGID bits

Manoj Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 10:57:53 PST 2021


manojgupta added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/mirror-permissions-win.test:35
+## Ignore umask if the output filename is the same as the input filename.
+# RUN: umask 022
+# RUN: cp %t %t1 && chmod 0777 %t1 && llvm-objcopy %t1
----------------
jhenderson wrote:
> I don't think this line will work. From the test comment at the top, "Windows has no umask". I don't appear to have it on my machine (which has GnuWin32 installed).
Yes, this is a good point about windows/umask . @MaskRay please consider removing or adjusting this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97253/new/

https://reviews.llvm.org/D97253



More information about the llvm-commits mailing list