[PATCH] D97253: [llvm-objcopy] If input=output, preserve umask bits, otherwise drop S_ISUID/S_ISGID bits

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I am not particular up-to-speed on the file permissions stuff, so I'll defer to @manojgupta for the rest of the change.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/mirror-permissions-win.test:35
+## Ignore umask if the output filename is the same as the input filename.
+# RUN: umask 022
+# RUN: cp %t %t1 && chmod 0777 %t1 && llvm-objcopy %t1
----------------
I don't think this line will work. From the test comment at the top, "Windows has no umask". I don't appear to have it on my machine (which has GnuWin32 installed).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97253/new/

https://reviews.llvm.org/D97253