[PATCH] D97299: [IR][SVE] Add new llvm.experimental.stepvector intrinsic

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/neon-stepvector.ll:147
+}
+
+
----------------
kmclaughlin wrote:
> Should there also be some tests here for illegal predicate types such as v32i1, as there are in sve-stepvector.ll?
Hi @kmclaughlin, thanks for pointing that out. So I originally did add some tests for illegal types for neon, but for some reason the i1 element types weren't being promoted to i8 and so we just ended up using GPRs instead, i.e. something like

`mov %x0, #some_immediate`

I thought it looked really odd and inconsistent with the legal types so I left them out. I'm not sure if that's a bug with the AArch64 backend for Neon or intended behaviour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97299/new/

https://reviews.llvm.org/D97299