[PATCH] D97299: [IR][SVE] Add new llvm.experimental.stepvector intrinsic

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1626
+  SDLoc dl(N);
+  assert(N->getValueType(0).isScalableVector());
+  std::tie(LoVT, HiVT) = DAG.GetSplitDestVTs(N->getValueType(0));
----------------
nit: can you add an error message to this assert?


================
Comment at: llvm/test/CodeGen/AArch64/neon-stepvector.ll:147
+}
+
+
----------------
Should there also be some tests here for illegal predicate types such as v32i1, as there are in sve-stepvector.ll?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97299/new/

https://reviews.llvm.org/D97299