[PATCH] D97349: [flang] Change existing runtime tests to use gtest
Asher Mancinelli via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 24 07:24:20 PST 2021
ashermancinelli added a comment.
In D97349#2584708 <https://reviews.llvm.org/D97349#2584708>, @awarzynski wrote:
>
> - Do all tests need `StartTests();` and `EndTests()` (thinking about `CharacterTest.cpp` again)? Also, shouldn't that be included in some test fixture <https://github.com/google/googletest/blob/master/docs/primer.md#test-fixtures-using-the-same-data-configuration-for-multiple-tests-same-data-multiple-tests>.
Yep! This seems like a better way to handle the runtime crashes. I'll have that for the next patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97349/new/
https://reviews.llvm.org/D97349
More information about the llvm-commits
mailing list