[PATCH] D97349: [flang] Change existing runtime tests to use gtest
Asher Mancinelli via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 24 07:22:57 PST 2021
ashermancinelli abandoned this revision.
ashermancinelli added a comment.
In D97349#2584802 <https://reviews.llvm.org/D97349#2584802>, @SouraVX wrote:
> Thanks for the patch! Could you please `clang-format` the patch(this is will remove lot of Lint warning/noise) and ease up the review.
> If you're using `arcanist` then that will automatically take care of formatting(provided `clang-format` should be in system path.) Or if you're using web UI then you may have to do it manually (`git-clang-format HEAD~`).
> More details: https://llvm.org/docs/Phabricator.html
Thank you for the note - I used arc like so:
$ arc diff a0839b14df6d
Linting...
OKAY No lint messages.
LINT OKAY No lint problems.
Running unit tests...
so it seems I'll have to clang-format manually.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97349/new/
https://reviews.llvm.org/D97349
More information about the llvm-commits
mailing list