[PATCH] D97276: [CodeGen] Canonicalise adds/subs of i1 vectors using XOR

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 05:40:15 PST 2021


RKSimon added a comment.

In D97276#2584555 <https://reviews.llvm.org/D97276#2584555>, @nikic wrote:

> Why is this in getNode() rather than DAGCombine? https://github.com/llvm/llvm-project/commit/6f5a805bbbed5d0cdaaf67846dffa7f044afb407 for example does something very similar in DAGCombine. What's the guideline for correct placement here?

Something that purely depends on the VT should be handled in getNode() - I can't recall the reasons I didn't put it there at the the time


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97276/new/

https://reviews.llvm.org/D97276



More information about the llvm-commits mailing list