[PATCH] D97336: [InstrProfiling] Use nobits for __llvm_prf_cnts with binutils >=2.28

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 17:01:02 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:445
+  // GNU binutils ld.bfd <2.28 has a bug which causes __start_/__stop_ symbols
+  // for SHT_NOBITS sections to have incorrect address
   if (Name == getInstrProfSectionName(IPSK_cnts, Triple::ELF,
----------------
Nit: end a complete sentence with a period.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97336/new/

https://reviews.llvm.org/D97336



More information about the llvm-commits mailing list