[PATCH] D97336: [InstrProfiling] Use nobits for __llvm_prf_cnts with binutils >=2.28

Tue Feb 23 17:00:20 PST 2021

MaskRay accepted this revision.
MaskRay added a comment.

Do you have a link for the bug? Might to good mentioning in the description.

================
Comment at: llvm/test/Instrumentation/InstrProfiling/X86/nobits.ll:2
 ;; Ensure that SHT_NOBITS section type is set for __llvm_prf_cnts in ELF.
-; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -binutils-version=2.27 | FileCheck %s --check-prefix=OLD
+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -binutils-version=2.28 | FileCheck %s --check-prefix=NEW
----------------
Nit: you can drop `-unknown-linux-gnu` because this tests generic ELF behavior.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97336/new/

https://reviews.llvm.org/D97336