[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 15:03:49 PST 2021


jsji added inline comments.


================
Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:211
                                     Expressions, Data.Regions);
     EXPECT_THAT_ERROR(Reader.read(), Succeeded());
   }
----------------
Somehow previous value of `Data.Filenames` will get corrupted after current call to `Reader.read`.
So we will actually get garbage filenames at the end, hence all getting different hash, so treated as not duplicated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95753/new/

https://reviews.llvm.org/D95753



More information about the llvm-commits mailing list