[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Just skimming, haven't had a chance to look closely.



================
Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:149
     if (R != Files.end())
       return R->second;
+    unsigned Index = Files.size() + 1;
----------------
assert(R->second > 0 && "Got index of compilation dir")?


================
Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:165
     if (R != CurrentFunctionFileMapping.end())
       return R->second;
     unsigned IndexInFunction = CurrentFunctionFileMapping.size();
----------------
Ditto.


================
Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:166
       return R->second;
     unsigned IndexInFunction = CurrentFunctionFileMapping.size();
     CurrentFunctionFileMapping.insert(
----------------
Does this need a +1?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95753/new/

https://reviews.llvm.org/D95753