[PATCH] D97207: [flang][test] Share all driver test dirs between `f18` and `flang-new`

Tue Feb 23 09:05:16 PST 2021

tskeith accepted this revision.
tskeith added inline comments.
This revision is now accepted and ready to land.

================
Comment at: flang/test/Frontend/prescanner-diag.f90:5
+! RUN: %flang -E -I %S/Inputs/ %s 2>&1 | FileCheck %s
+! RUN: %flang_fc1 -E -I %S/Inputs/ %s 2>&1 | FileCheck %s

----------------
awarzynski wrote:
> tskeith wrote:
> > I think you need to keep the `%f18` command so that the test is run on f18 when the new driver is enabled. Unfortunately that means when it is disabled the same test is run on f18 three times, but none of these should take much time.
> Do we _want_ to test `f18` when the new driver is enabled?
> 
> I'm fine to keep `%f18` here, but so far we've been using `%flang` and `%flang_fc1` for tests that are shared between the drivers. We've already ported quite a few tests this way (e.g. preprocessor tests) and diverging from that approach might be confusing for us later. 
OK, that makes sense. I guess devs working on the new driver have to do a build with the new driver disabled anyway to be sure the tests still pass with f18. I was thinking that could be avoided, but maybe not.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97207/new/

https://reviews.llvm.org/D97207