[PATCH] D97207: [flang][test] Share all driver test dirs between `f18` and `flang-new`

Tue Feb 23 08:38:17 PST 2021

awarzynski added a comment.

In D97207#2579523 <https://reviews.llvm.org/D97207#2579523>, @tskeith wrote:

> It looks like there are other tests in Flang-Driver that can be run on f18 as well. That doesn't have to happen in this change if you prefer not to.

Thank you for reviewing Tim!

Yes, I'll port other tests separately. This patch is mostly about enabling  https://reviews.llvm.org/D97197.

================
Comment at: flang/test/Frontend/prescanner-diag.f90:5
+! RUN: %flang -E -I %S/Inputs/ %s 2>&1 | FileCheck %s
+! RUN: %flang_fc1 -E -I %S/Inputs/ %s 2>&1 | FileCheck %s

----------------
tskeith wrote:
> I think you need to keep the `%f18` command so that the test is run on f18 when the new driver is enabled. Unfortunately that means when it is disabled the same test is run on f18 three times, but none of these should take much time.
Do we _want_ to test `f18` when the new driver is enabled?

I'm fine to keep `%f18` here, but so far we've been using `%flang` and `%flang_fc1` for tests that are shared between the drivers. We've already ported quite a few tests this way (e.g. preprocessor tests) and diverging from that approach might be confusing for us later. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97207/new/

https://reviews.llvm.org/D97207