[PATCH] D97194: [RISCV] Support fixed-length vector sign/zero extension

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-exttrunc.ll:15
+; CHECK-NEXT:    vle8.v v25, (a0)
+; CHECK-NEXT:    vsetvli a0, a2, e32,m4,ta,mu
+; CHECK-NEXT:    vsext.vf4 v28, v25
----------------
craig.topper wrote:
> This is using LMUL 4 for a result that fits in 128 bits. Should we be getting the container from the destination and deriving the source lmul from it instead?
That was what I tried at first, but I was seeing incorrect codegen when it came to split legalized vectors and subvector extraction. It seems to have resolved itself now though so I was obviously wrong about where the bug was. I've fixed this up now, cheers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97194/new/

https://reviews.llvm.org/D97194