[llvm] bb16efe - [AMDGPU] Move RPT::getLiveRegs() check under EXPENSIVE_CHECKS

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 15:22:09 PST 2021


Author: Stanislav Mekhanoshin
Date: 2021-02-22T15:21:59-08:00
New Revision: bb16efe28030e26f9e5e0eaecfe729a3f1ff2ca7

URL: https://github.com/llvm/llvm-project/commit/bb16efe28030e26f9e5e0eaecfe729a3f1ff2ca7
DIFF: https://github.com/llvm/llvm-project/commit/bb16efe28030e26f9e5e0eaecfe729a3f1ff2ca7.diff

LOG: [AMDGPU] Move RPT::getLiveRegs() check under EXPENSIVE_CHECKS

This is too expensive even for debug builds. It doubles
scheduling time if enabled.

Differential Revision: https://reviews.llvm.org/D97232

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp b/llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp
index 18a534d28b21..04778561fc8b 100644
--- a/llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp
@@ -461,7 +461,9 @@ void GCNScheduleDAGMILive::computeBlockPressure(const MachineBasicBlock *MBB) {
     I = Rgn.first;
     auto *NonDbgMI = &*skipDebugInstructionsForward(Rgn.first, Rgn.second);
     auto LRS = BBLiveInMap.lookup(NonDbgMI);
+#ifdef EXPENSIVE_CHECKS
     assert(isEqual(getLiveRegsBefore(*NonDbgMI, *LIS), LRS));
+#endif
     RPTracker.reset(*I, &LRS);
   }
 


        


More information about the llvm-commits mailing list