[PATCH] D97212: [lld-link] Add /reproduce: support for several flags

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lld/COFF/Driver.cpp:633
+// the same command with the same inputs. This is for --reproduce.
 static std::string createResponseFile(const opt::InputArgList &args,
                                       ArrayRef<StringRef> filePaths,
----------------
rnk wrote:
> (nit) Descriptive names can be more helpful than comments. The comment is fine, but how about renaming to `createReproducerRspFile` or `createRspFileForReproduce`?
The ELF and MachO ports also have the same comment. I can rename all versions of these functions and remove the comments in a follow-up :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97212/new/

https://reviews.llvm.org/D97212