[PATCH] D97212: [lld-link] Add /reproduce: support for several flags

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 13:12:44 PST 2021


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/COFF/Driver.cpp:633
+// the same command with the same inputs. This is for --reproduce.
 static std::string createResponseFile(const opt::InputArgList &args,
                                       ArrayRef<StringRef> filePaths,
----------------
(nit) Descriptive names can be more helpful than comments. The comment is fine, but how about renaming to `createReproducerRspFile` or `createRspFileForReproduce`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97212/new/

https://reviews.llvm.org/D97212



More information about the llvm-commits mailing list