[PATCH] D96757: [InstrProfiling] Use ELF section groups for counters, data and values

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 09:14:16 PST 2021


Thanks for the heads up. I've landed
https://github.com/llvm/llvm-project/commit/97184ab99c46e35ae94f828ee90f5d6af2c47e11
which should have addressed that issue, but now the bot is failing with a
different issue that looks like a stale output. I'm still looking into it,
but if I cannot find a culprit quickly, I'll revert the change.

On Mon, Feb 22, 2021 at 2:44 AM Yvan Roux <yvan.roux at linaro.org> wrote:

> Hi Petr,
>
> This commit broke AArch64 LLD bot, logs are available here:
>
> http://lab.llvm.org:8011/#/builders/53/builds/1366
>
> Cheers,
> Yvan
>
> On Mon, 22 Feb 2021 at 05:22, Xinliang David Li via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>>
>>
>> On Sun, Feb 21, 2021 at 2:36 PM Petr Hosek via Phabricator <
>> reviews at reviews.llvm.org> wrote:
>>
>>> phosek added a comment.
>>>
>>> I plan on improving how `__llvm_prf_names` is constructed using the
>>> approach suggested in PR49155 in a follow up change.
>>>
>>
>>
>> Compression can reduce per object size and therefore the size of total
>> linker input.
>>
>> If the size of name section in the final binary is the concern, we can
>> make the name section non loadable (like coverage map) then it can be
>> stripped from the binary and put into its own file. The llvm_profdata tool
>> will need to read this file in order to produce the index format because
>> names won't available in the raw profile any more.  The downside of this
>> approach is the reduced usability.
>>
>> David
>>
>>
>>
>>>
>>>
>>> Repository:
>>>   rG LLVM Github Monorepo
>>>
>>> CHANGES SINCE LAST ACTION
>>>   https://reviews.llvm.org/D96757/new/
>>>
>>> https://reviews.llvm.org/D96757
>>>
>>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210222/52ad5c0e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3996 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210222/52ad5c0e/attachment.bin>


More information about the llvm-commits mailing list