[PATCH] D96757: [InstrProfiling] Use ELF section groups for counters, data and values

Yvan Roux via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 02:44:44 PST 2021


Hi Petr,

This commit broke AArch64 LLD bot, logs are available here:

http://lab.llvm.org:8011/#/builders/53/builds/1366

Cheers,
Yvan

On Mon, 22 Feb 2021 at 05:22, Xinliang David Li via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
>
> On Sun, Feb 21, 2021 at 2:36 PM Petr Hosek via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> phosek added a comment.
>>
>> I plan on improving how `__llvm_prf_names` is constructed using the
>> approach suggested in PR49155 in a follow up change.
>>
>
>
> Compression can reduce per object size and therefore the size of total
> linker input.
>
> If the size of name section in the final binary is the concern, we can
> make the name section non loadable (like coverage map) then it can be
> stripped from the binary and put into its own file. The llvm_profdata tool
> will need to read this file in order to produce the index format because
> names won't available in the raw profile any more.  The downside of this
> approach is the reduced usability.
>
> David
>
>
>
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D96757/new/
>>
>> https://reviews.llvm.org/D96757
>>
>> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210222/656f20e4/attachment.html>


More information about the llvm-commits mailing list