[PATCH] D97130: [RISCV] Have sexti32 also recognize AssertZExt from types smaller than i32.
    Fraser Cormack via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Feb 22 07:35:57 PST 2021
    
    
  
frasercrmck added a comment.
LGTM though I'll defer my acceptance to @asb or @luismarques who have more to do with the non-vector side of things.
I do think it makes sense to do this in a `ComplexPattern` rather than have them all in the table. I've never liked how many forms of `sext`/`zext`/`trunc` there can be when doing pattern matching at this stage. I'm surprised there hasn't been an effort to unify it as it's often infeasible (or, easy to forget) to cover all the cases.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97130/new/
https://reviews.llvm.org/D97130
    
    
More information about the llvm-commits
mailing list