[PATCH] D97040: [llvm-objcopy][MachO] Add support for --keep-undefined

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:535-537
+  if (Config.StripSwiftSymbols || Config.KeepUndefined)
     return createStringError(llvm::errc::invalid_argument,
                              "option not supported by llvm-objcopy for ELF");
----------------
jhenderson wrote:
> Obvious question a user will ask: what option? I know this message was here before, but it probably wants improving, especially now that there is more than one option.
This is analogous to COFFObjcopy.cpp (253 - 264), MachOObjcopy.cpp (331 - 345).
In general I think it would be better if the tool reported which particular option is not supported.
I'm a little hesitant to add ad-hoc code here because this will diverge from what's going on in COFF and Mach-O, and, probably, a more systematic solution would be desired, but this is not the goal of this diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97040/new/

https://reviews.llvm.org/D97040