[PATCH] D97040: [llvm-objcopy][MachO] Add support for --keep-undefined

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CommonOpts.td:88
+def keep_undefined : Flag<["--"], "keep-undefined">,
+                        HelpText<"Do not remove undefined symbols">;
+
----------------
jhenderson wrote:
> This probably wants a note saying this is Mach-O only.
> 
> More generally, it might be worth separating options for specific platforms into different parts of the help text, like some other tools do, and like the docs do. That's probably a separate issue though.
this would make the help text a bit inconsistent with other options (including those which are format-specific).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97040/new/

https://reviews.llvm.org/D97040