[PATCH] D96663: [InstCombine] Fold nonnull (select c,null,p) to nonnull p

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 20 17:49:49 PST 2021


aqjune added reviewers: lebedev.ri, spatel.
aqjune added a comment.

I think we can say that this is conceptually equivalent to SimplifyCFG that removes a conditional branch, and SimplifyCFG inserts an assumption when removing a condition (`test9_null_callsite` at `llvm/test/Transforms/SimplifyCFG/UnreachableEliminate.ll`), so this transformation is also chosen to insert assume.
To speak generally, we can say that control flow information is preserved using assume in InstCombine, and the scheme should be consistent with what SimplifyCFG says.
But would it be a big change though?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96663/new/

https://reviews.llvm.org/D96663



More information about the llvm-commits mailing list