[PATCH] D96663: [InstCombine] Fold nonnull (select c,null,p) to nonnull p

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I don't think this should be creating assumptions. It's pretty common for InstCombine transforms to lose //some// information while making folds, and we currently don't have any other InstCombine folds that try to preserve information through assumptions. Unless there is something specific to this transform that makes this particularly worthwhile, we should not deviate from the general pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96663/new/

https://reviews.llvm.org/D96663