[PATCH] D96164: [lld-macho] add code signature for native arm64 macOS

[Paul via Phabricator via llvm-commits]

cynecx added inline comments.


================
Comment at: lld/MachO/SyntheticSections.h:489
+public:
+  const uint8_t blockSizeShift = 12;
+  const ssize_t blockSize = (1 << blockSizeShift); // 4 KiB
----------------
gkm wrote:
> cynecx wrote:
> > constexpr?
> Comments elsewhere say that `static constexpr` members are broken in MSC, so I avoided them.
I think those comments are outdated because according to https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library, llvm requires >= Visual Studio 2017, which iirc properly supports constexpr. Also there are many places where llvm code utilizes "static constexpr".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96164/new/

https://reviews.llvm.org/D96164