[PATCH] D96164: [lld-macho] add code signature for native arm64 macOS

Greg McGary via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 19:01:45 PST 2021


gkm marked 4 inline comments as done.
gkm added inline comments.


================
Comment at: lld/MachO/SyntheticSections.h:489
+public:
+  const uint8_t blockSizeShift = 12;
+  const ssize_t blockSize = (1 << blockSizeShift); // 4 KiB
----------------
cynecx wrote:
> constexpr?
Comments elsewhere say that `static constexpr` members are broken in MSC, so I avoided them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96164/new/

https://reviews.llvm.org/D96164



More information about the llvm-commits mailing list