[PATCH] D96979: [DSE] Extending IsGuaranteedLoopInvariant to support a GetElementPtrInst defined in the entry block

Sat Feb 20 04:27:30 PST 2021

fhahn added a comment.

In D96979#2576543 <https://reviews.llvm.org/D96979#2576543>, @fvrmatteo wrote:

> @fhahn I verified the similar logic in `MemorySSA.cpp`, but I think the unification should be part of a different patch, right?

Yep, the current patch can be submitted as is.

> Should we try to come up with a single function that we can call both from `MemorySSA.cpp` and `DeadStoreElimination.cpp` or should we keep them separated but semantically equivalent (therefore porting this addition to the `MemorySSA.cpp` version of the function)?

I think we should be able to use the same function for both. It would probably be easiest to make this accessible through `MemorySSA.h`. It's not directly MemorySSA related, but I'm not sure if there's a more suitable place.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96979/new/

https://reviews.llvm.org/D96979