[PATCH] D96979: [DSE] Extending IsGuaranteedLoopInvariant to support a GetElementPtrInst defined in the entry block

Matteo Favaro via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 20 03:09:06 PST 2021


fvrmatteo added a comment.

@fhahn I verified the similar logic in `MemorySSA.cpp`, but I think the unification should be part of a different patch, right? Should we try to come up with a single function that we can call both from `MemorySSA.cpp` and `DeadStoreElimination.cpp` or should we keep them separated but semantically equivalent (therefore porting this addition to the `MemorySSA.cpp` version of the function)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96979/new/

https://reviews.llvm.org/D96979



More information about the llvm-commits mailing list