[PATCH] D97106: [UpdateTestChecks] Warn if any function conflicts under the same prefix

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:275
   def finish_and_get_func_dict(self):
-    for prefix in self._get_failed_prefixes():
-      warn('Prefix %s had conflicting output from different RUN lines for all functions' % (prefix,))
+    for prefix, funcs in self._get_failed_prefixes():
+      warn('Prefix %s had conflicting output from different RUN lines for functions: %s' % (
----------------
I think the warn only conflicting for all functions is used for the multi prefixes case, e.g. `--check-prefixes=A,B;--check-prefixes=A,C` when we hope the conflicted functions use B and C respectively. Under which case, warn A conflicted is annoying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97106/new/

https://reviews.llvm.org/D97106