[PATCH] D97106: [UpdateTestChecks] Warn if any function conflicts under the same prefix

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 19:34:40 PST 2021


mtrofin added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:339
 
   def _get_failed_prefixes(self):
+    # This returns the list of those prefixes that failed to match some functions,
----------------
Nit: may be worth renaming this function to more accurately reflect its new behavior. For example: _get_prefixes_failing_functions (or better name).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97106/new/

https://reviews.llvm.org/D97106



More information about the llvm-commits mailing list