[PATCH] D96981: [SampleFDO][NFC] Refactor: make SampleProfileLoaderBaseImpl a template class

[Rong Xu via Phabricator via llvm-commits]

xur added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h:52
+
+template <typename BlockT> struct IRTraits {};
+template <> struct IRTraits<BasicBlock> {
----------------
dblaikie wrote:
> This can be reduced to a declaration - might make for better compilation errors if the template is used without a specialization. 
Good point. Will change to a declaration.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96981/new/

https://reviews.llvm.org/D96981