[PATCH] D96981: [SampleFDO][NFC] Refactor: make SampleProfileLoaderBaseImpl a template class

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 15:10:27 PST 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, thanks!



================
Comment at: llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h:52
+
+template <typename BlockT> struct IRTraits {};
+template <> struct IRTraits<BasicBlock> {
----------------
This can be reduced to a declaration - might make for better compilation errors if the template is used without a specialization. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96981/new/

https://reviews.llvm.org/D96981



More information about the llvm-commits mailing list