[PATCH] D96904: [IR] restrict vector reduction intrinsic types

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 09:23:46 PST 2021


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:5064
            "second operand of [us][add|sub|shl]_sat must be an int type or "
            "vector of ints");
     break;
----------------
nikic wrote:
> Side note: The checks for these intrinsics look unnecessary. This should already be ensured by the tablegen definitions.
Those were added in stages with:
D53053
D53340
D53783
D83216

I don't see any Verifier regression tests for these. I can add some in a separate patch and clean up.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96904/new/

https://reviews.llvm.org/D96904



More information about the llvm-commits mailing list