[PATCH] D96904: [IR] restrict vector reduction intrinsic types

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 07:02:05 PST 2021


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/IR/Verifier.cpp:5064
            "second operand of [us][add|sub|shl]_sat must be an int type or "
            "vector of ints");
     break;
----------------
Side note: The checks for these intrinsics look unnecessary. This should already be ensured by the tablegen definitions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96904/new/

https://reviews.llvm.org/D96904



More information about the llvm-commits mailing list