[PATCH] D89693: [AArch64] Favor post-increments and implement TTI::getPreferredAddressingMode
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 19 08:16:15 PST 2021
fhahn added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1287
+ InductionDescriptor IndDesc;
+ if (!L->getInductionDescriptor(*SE, IndDesc))
+ return TTI::AMK_None;
----------------
What if the loop has multiple induction phis and one of those has a large constant step or unknown step? Should we instead iterate over all phis and check all induction phis (using `InductionDescriptor::isInductionPHI` to identify them)?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89693/new/
https://reviews.llvm.org/D89693
More information about the llvm-commits
mailing list