[PATCH] D89693: [AArch64] Favor post-increments and implement TTI::getPreferredAddressingMode

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 03:59:58 PST 2021


SjoerdMeijer updated this revision to Diff 324940.
SjoerdMeijer retitled this revision from "[AArch64] Favor post-increments" to "[AArch64] Favor post-increments and implement TTI::getPreferredAddressingMode".
SjoerdMeijer edited the summary of this revision.
SjoerdMeijer added a comment.

This is now "rebased" on the changes that introduced `getPreferredAddressingMode`, see also the updated title/description of this change.

I have rerun numbers and not much has fundamentally changed: this is a good thing to do. The only new insight is that if we also start doing runtime loop, the picture changes slightly. In that case, preindexed addressing modes are better. But with `getPreferredAddressingMode` now in place, we can easily adapt to that (see also my comment in the implementation of getPreferredAddressingMode) when we start doing that, which is what we will be looking into next.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89693/new/

https://reviews.llvm.org/D89693

Files:
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h
  llvm/test/CodeGen/AArch64/ragreedy-local-interval-cost.ll
  llvm/test/CodeGen/AArch64/shrink-wrapping-vla.ll
  llvm/test/CodeGen/AArch64/vldn_shuffle.ll
  llvm/test/Transforms/LoopStrengthReduce/AArch64/small-constant.ll
  llvm/test/Transforms/LoopStrengthReduce/AArch64/vscale-factor-out-constant.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89693.324940.patch
Type: text/x-patch
Size: 30087 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210219/2af8a4ec/attachment.bin>


More information about the llvm-commits mailing list