[PATCH] D97036: [X86] Fix a codegen crash in getSetCCResultType

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck accepted this revision.
frasercrmck added a comment.

In D97036#2574085 <https://reviews.llvm.org/D97036#2574085>, @craig.topper wrote:

> Oh I see. changeVectorElementType assumes that if the type is simple and type to change to is simple it will succeed in MVT. That seems like a poor implementation. Maybe it should check the result and fallback to the extended implementation of it fails on MVT?

Yeah that's.. questionable. I'd +1 that change.

This change, though, LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97036/new/

https://reviews.llvm.org/D97036