[PATCH] D97036: [X86] Fix a codegen crash in getSetCCResultType
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 19 01:23:40 PST 2021
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
Oh I see. changeVectorElementType assumes that if the type is simple and type to change to is simple it will succeed in MVT. That seems like a poor implementation. Maybe it should check the result and fallback to the extended implementation of it fails on MVT?
This patch seems fine though. LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97036/new/
https://reviews.llvm.org/D97036
More information about the llvm-commits
mailing list