[PATCH] D97033: [RISCV] Use custom isel for vector indexed load/store intrinsics.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 01:07:18 PST 2021


craig.topper added a comment.

In D97033#2574011 <https://reviews.llvm.org/D97033#2574011>, @khchen wrote:

> LGTM!!
>
> I'm little curious, what's benefit to have two GenericTables for load/store? 
> Why not add a `isLoad` field in FilterClass and using one GenericTable for VLX and VSX?
> because we have two identical FilterClass, RISCVVLX and RISCVVSX.

I might do that. I think there is a free byte of padding in each row of the table so it doesn’t cost anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97033/new/

https://reviews.llvm.org/D97033



More information about the llvm-commits mailing list