[PATCH] D96980: [amdgpu] Revert agnostic SGPR spill.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 15:59:27 PST 2021


hliao added a comment.

In D96980#2572918 <https://reviews.llvm.org/D96980#2572918>, @arsenm wrote:

> Conflicts with D96336 <https://reviews.llvm.org/D96336>/D96517 <https://reviews.llvm.org/D96517>

Just have brief look on that two changes, they seem always manipulate the exec mask explicitly and should have the same issue on clobbering global VGPRs. We should not change the current exec mask if we need a temp VGPR during SGPR spilling. That's quite risky that a global VGPR is clobbered.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96980/new/

https://reviews.llvm.org/D96980



More information about the llvm-commits mailing list