[PATCH] D96949: [FuncAttrs] Add willreturn to readonly callsites in mustprogress fns.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D96949#2571913 <https://reviews.llvm.org/D96949#2571913>, @jeroen.dobbelaere wrote:

> I am not sure if this is completely true. When looking at the test changes for D96960 <https://reviews.llvm.org/D96960>, I have the impression that a lot of __builtin_xxx functions might also need the 'willreturn' attribute. (and for 'C', it should  be clang that adds the attribute).

That may well be, but in that case we really need to get the attribute directly on the `__builtin` functions, otherwise the issue would persist for C.

Do you have any particular examples? I would expect that most builtins get lowered to intrinsics and those should already have all the necessary attributes, but there's probably some cases that fell through.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96949/new/

https://reviews.llvm.org/D96949