[PATCH] D96949: [FuncAttrs] Add willreturn to readonly callsites in mustprogress fns.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1464
+}
+
 static bool functionWillReturn(const Function &F) {
----------------
fhahn wrote:
> jdoerfert wrote:
> > You could track if any call was not willreturn to avoid doing so in `functionWillReturn`.
> I updated the code but due to the early exit I think we need to track the possibility that we did not analyze the call sites, so unfortunately it's a bit more complicated.
Yeah, I see that now. The design here was not meant to couple those things. Unsure if this is better :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96949/new/

https://reviews.llvm.org/D96949