[PATCH] D96949: [FuncAttrs] Add willreturn to readonly callsites in mustprogress fns.

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added a comment.

In D96949#2571873 <https://reviews.llvm.org/D96949#2571873>, @nikic wrote:

> After D96960 <https://reviews.llvm.org/D96960> I don't think this change is really necessary anymore (at least it does not need an LLVM 12 backport). If the language has forward progress, then all function definitions will get annotated anyway, so only extern declarations are relevant. However, those will not be readyonly either -- unless they are explicitly annotated such, in which case they will also be annotated as willreturn after D96960 <https://reviews.llvm.org/D96960>.

I am not sure if this is completely true. When looking at the test changes for D96960 <https://reviews.llvm.org/D96960>, I have the impression that a lot of __builtin_xxx functions might also need the 'willreturn' attribute. (and for 'C', it should  be clang that adds the attribute).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96949/new/

https://reviews.llvm.org/D96949