[PATCH] D96949: [FuncAttrs] Add willreturn to readonly callsites in mustprogress fns.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

After D96960 <https://reviews.llvm.org/D96960> I don't think this change is really necessary anymore (at least it does not need an LLVM 12 backport). If the language has forward progress, then all function definitions will get annotated anyway, so only extern declarations are relevant. However, those will not be readyonly either -- unless they are explicitly annotated such, in which case they will also be annotated as willreturn after D96960 <https://reviews.llvm.org/D96960>.

(I do think that doing callsite attribute inference is *generally* valuable, the comment here is more along the lines that it does not seem necessary to implement this as a quick fix for just willreturn to prevent regressions.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96949/new/

https://reviews.llvm.org/D96949