[PATCH] D96957: [AVR] Fix rotate instructions

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 07:22:17 PST 2021


aykevl created this revision.
aykevl added reviewers: dylanmckay, benshi001.
Herald added subscribers: Jim, hiraditya.
aykevl requested review of this revision.
Herald added a project: LLVM.

This patch fixes two issues:

- A minor issue in which the instructions were said to use the SREG, which is not true.
- A major issue in which invalid instructions were generated. The fix also reduce RORB from 4 to 3 instructions, so it's also a small optimization.

Both of these issues were flagged by the machine verifier.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96957

Files:
  llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp
  llvm/lib/Target/AVR/AVRInstrInfo.td
  llvm/test/CodeGen/AVR/rot.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96957.324625.patch
Type: text/x-patch
Size: 3540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210218/ccc991b4/attachment.bin>


More information about the llvm-commits mailing list